image: inject firstboot kargs (ignition-network-kcmdline) #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `image` manifest to capture current firstboot kernel arguments. Those are effectively the same parameters used by GRUB and overridable by coreos-installer, which so far have been hardcoded inside `grub.cfg`.
This was referenced May 26, 2020
ashcrow
approved these changes
May 26, 2020
jlebon
approved these changes
May 26, 2020
dustymabe
pushed a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
Triggered by update-versions GitHub Action. Co-authored-by: CoreOS Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
imagemanifest to capture current firstboot kernelarguments. Those are effectively the same parameters used by GRUB
and overridable by coreos-installer, which so far have been
hardcoded inside
grub.cfg.Ref: coreos/coreos-assembler#1373