-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs/build-development: make development streams build daily #973
base: main
Are you sure you want to change the base?
Conversation
Over time I'm thinking the build on every push to the git repo is a bit heavy. Often times the changes will be insignificant to warrant building, testing, and pushing all that we do. On the other hand, if there is a change we want we can easily click a button and start a build if we don't want to wait.
pipelineTriggers(pipeutils.get_push_trigger()), | ||
pipelineTriggers([ | ||
// run every 24h only for now | ||
cron("H H * * *") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this timer wouldn't coincide/run at exactly the same time each day as build-mechanical
right? Otherwise we'd want to do something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins have a built-in feature to randomize the start hours while respecting the periodicity, when you write H
https://www.jenkins.io/doc/book/pipeline/syntax/#cron-syntax
So from my understanding this should be good
This ticket is meant more to be a discussion about the change. If we agree we can merge this, but let's have the conversation first. |
This is about |
correct |
Had a chat with Dusty about this. Things we mentioned:
|
@jlebon just to make sure i understand that correctly, you mean the job wouldn't start if it haven't been idle for at least 20 hours ? |
When the job starts, it would check when the last build on that stream was. If it's less than X hours ago, then we no-op. |
Over time I'm thinking the build on every push to the git repo is a bit heavy. Often times the changes will be insignificant to warrant building, testing, and pushing all that we do. On the other hand, if there is a change we want we can easily click a button and start a build if we don't want to wait.