This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
agent,unit: check errors from start/stop/unload-ing unit #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2016 14:08
Now that it's possible to retrieve an error from a.um.TriggerStop(), a.um.Unload() should be able to return an error for consistency. Also the error should be delivered up to mapTaskToFunc() not to be ignored from the task manager.
Now that UnitManager.Trigger{Start,Stop}() could return an error, the
error should be delivered up to mapTaskToFunc(), not to be ignored by
the task manager. Doing that, we can fix a bug in fleet ignoring failed
attempt to start/stop a unit.
Fixes coreos#998
| // removing the unit file. Otherwise "systemctl stop fleet" could end up | ||
| // hanging forever. | ||
| var errf error | ||
| func(name string) { |
There was a problem hiding this comment.
What's the purpose of these closures?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that UnitManager.{TriggerStart,TriggerStop,Unload}() could return an error, the error should be delivered up to
mapTaskToFunc(), not to be ignored by the task manager. Doing that, we can fix a bug in fleet ignoring failed attempt to start/stop a unit.Fixes #998