This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
*: avoid using err.Error() #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2016 12:06
In principle we should avoid returning err.Error(). Instead we should just return err, to be able to inspect the error in a flexible way.
rpcRenewLeadership() should check for an exact error code from etcd, EcodeKeyNotFound, instead of comparing error string with a particular string pattern. Doing that, we can also avoid using err.Error().
dongsupark
force-pushed
the
dongsu/cleanup-error-method
branch
11 times, most recently
from
58736a2
to
dbc9102
Compare
Add github.com/coreos/etcd/error for dependencies.
|
Will merge this PR tomorrow, in case of no objection. |
dongsupark
pushed a commit
that referenced
this pull request
Aug 30, 2016
*: avoid using err.Error()
dongsupark
pushed a commit
that referenced
this pull request
Aug 30, 2016
*: avoid using err.Error()
dongsupark
pushed a commit
that referenced
this pull request
Aug 30, 2016
*: avoid using err.Error()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle we should avoid returning
err.Error(). Instead we should just return err, to be able to inspect the error in a flexible way.Also in
rpcRenewLeadership()check for an exact error code from etcd,EcodeKeyNotFound, instead of comparing error string with a particular string pattern. Doing that, we can also avoid usingerr.Error().