Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

dracut/30ignition: Propagate kargs by default, add coreos.no_persist_ip to opt-out #89

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

arithx
Copy link
Contributor

@arithx arithx commented Jul 9, 2019

When coreos.no_persist_ip is specified on the kcmdline delete
/etc/sysconfig/network-scripts that was created by the dracut
write-ifcfg.sh script before running Ignition. This allows the use
case of configuring only the initial initramfs networking via ip= to
allow fetching of the Ignition config, and specifying a more complex
real root configuration in the Ignition config.

When `coreos.no_persist_ip` is not specified in a true value persist
ifcfg files created by the `write-ifcfg.sh` script run as part of the
dracut `45ifcfg` module to the real root.
@arithx arithx marked this pull request as ready for review July 19, 2019 21:14
Copy link
Contributor

@darkmuggle darkmuggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters
Copy link
Member

So this was only merged into the spec2x branch...I guess because FCOS (spec3) doesn't have ifcfg files. But it's going to require us to...hmm, add a new translator to NM config files or something.
Or I guess maybe we could just merge this in master and ignore that it doesn't do anything for FCOS yet.

@cgwalters cgwalters changed the title dracut/30ignition: support coreos.no_persist_ip dracut/30ignition: Propagate kargs by default, add coreos.no_persist_ip to opt-out Oct 29, 2019
@cgwalters
Copy link
Member

Side note: The way I've been testing out changes to this is to cosa run and edit the kernel cmdline to say ip=on. This tricks the code that skips over ip=dhcp.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants