Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS: add news for v0.28.0 #622

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Conversation

ajeddeloh
Copy link
Contributor

No description provided.

NEWS Outdated

Features:

- Refactor blackbox tests to allow for testing with disks with 4k sectors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/allow for/allow/?
s/testing with/testing/?

NEWS Outdated

Bug Fixes:

- Detect disks with 4k sectors correctly when scanning existing partitions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly detect disks with 4k sectors when

NEWS Outdated

- Detect disks with 4k sectors correctly when scanning existing partitions
- Fix race between HTTP backoff tests
- Set the minimum config version to the actual minimum required in tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the minimum config versions in tests to the actual minimum required

NEWS Outdated
- Detect disks with 4k sectors correctly when scanning existing partitions
- Fix race between HTTP backoff tests
- Set the minimum config version to the actual minimum required in tests
- Relabel /root as well when relabeling with SELinux enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relabel /root when SELinux relabeling is enabled

@ajeddeloh
Copy link
Contributor Author

Fixed

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've gotten in the habit of grouping test changes alongside actual Ignition changes. The test changes are not user-facing and add clutter, so I wonder if we should start omitting them or putting them in a separate block.

NEWS Outdated

- Correctly detect disks with 4k sectors when scanning existing partitions
- Fix race between HTTP backoff tests
- Set the minimum config versions in tests to the actual minimum required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing space.

@ajeddeloh ajeddeloh merged commit f707912 into coreos:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants