Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Clarify that intermediates are created for files/directories #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Jan 18, 2019

For files it looks like root:root and moe 0755 parents. For
directories we use the target's perms.

@coreosbot
Copy link
Contributor

Can one of the admins verify this patch?

For files it looks like `root:root` and moe `0755` parents.  For
directories we use the target's perms.
@cgwalters cgwalters changed the title doc: Clarify that intermediate directories are created for files/dire… doc: Clarify that intermediates are created for files/directories Jan 18, 2019
@bgilbert
Copy link
Contributor

ok to test

@ajeddeloh
Copy link
Contributor

minor nit: we try to keep commit titles to 50 chars. We're actually looking to change this for directories for spec 3.0.0 (make it the same as files/links). I'm fine with merging anyway since it reflects current behavior. This should also be PRd to the spec2x branch though.

@ashcrow
Copy link
Member

ashcrow commented Feb 20, 2019

@ajeddeloh is the commit message the only thing keeping this from merging at this point? Or does it still need full review?

Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ajeddeloh
Copy link
Contributor

Yeah, that's the only nit. @cgwalters feel free to just fixup and merge

@sohankunkerkar
Copy link
Member

@cgwalters Is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants