Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift 'override' out of experimental #1089

Closed
wants to merge 2 commits into from

Conversation

cgwalters
Copy link
Member

We have a lot of experimental functionality. I think the
override bits are fleshed out enough now that we can lift
the ex designation. For example, jlebon fixed SELinux
labeling in the presence of override-replace.

We have a *lot* of experimental functionality.  I think the
`override` bits are fleshed out enough now that we can lift
the `ex` designation.  For example, jlebon fixed SELinux
labeling in the presence of override-replace.
@dustymabe
Copy link
Member

There are quite a few issues I opened back when livefs was first introduced that haven't been resolved:

and to a lesser extent some design discussion:

I'd prefer not to lift experimental from livefs without trying to close out those issues/discussions.

@dustymabe
Copy link
Member

🤦‍♂️ - I totally read that as lift livefs out of experimental. Sorry - disgregard my earlier comment.

@jlebon
Copy link
Member

jlebon commented Nov 8, 2017

Our overrides are all grown up. 😂
@rh-atomic-bot r+ 0cc8032

@dustymabe
Copy link
Member

a few questions:

  • can we override with a package that is in a yum repo and not a local package?
  • should we leave some sort of compatibility in place for people who may have already scripted rpm-ostree ex override ?

@rh-atomic-bot
Copy link

⌛ Testing commit 0cc8032 with merge 407bfd5...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: jlebon
Pushing 407bfd5 to master...

@cgwalters
Copy link
Member Author

can we override with a package that is in a yum repo and not a local package?

Not implemented yet, no.

should we leave some sort of compatibility in place for people who may have already scripted rpm-ostree ex override ?

It's a valid concern. I don't think we should be maintaining the ex versions forever but I can see an argument for having both for a while. In this particular case...dunno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants