Turn staged deployments on by default #1430

cgwalters · 2018-06-27T12:24:15Z

Let's use this PR to track turning it on by default. I'd like to
do that after the next release. So far, everything seems fine.

jlebon · 2018-06-27T13:18:08Z

I haven't hit any issues either and haven't heard of anyone else hitting issues. So I'm +1 for enabling it next release!

cgwalters · 2018-06-27T13:25:44Z

OK, looks like various things are going to need fixes, for example livefs. Which actually gets easier with staging enabled by default I think.

Some interesting questions here - the misc-2 failure around rollback - do we error out on that if the deployment is staged? Probably. So we should make that bit conditional on !staged.

dustymabe · 2018-06-27T13:29:19Z

could we possibly enable this in rawhide for a month before we enable by default?

cgwalters · 2018-06-27T14:01:19Z

could we possibly enable this in rawhide for a month before we enable by default?

Sure, would just need some fairly trivial build-time machinery here (--enable-staged) and in the spec.

jlebon · 2018-06-28T16:45:55Z

Hmm, OK yeah just hit the rollback one locally. Let's say we fix those before releasing? Will have a look in a bit.

jlebon · 2018-06-28T18:56:15Z

So, apart from #1434, it seems like all the other failures are either pure test adaptations or due to livefs handling of staged deployments. Given that livefs and StagedDeployments are both still experimental, I think we can leave the rest for after the release?

cgwalters · 2018-06-28T19:08:15Z

I think we can leave the rest for after the release?

Yep - to make sure I understand, you want to fix staged+rollback before the release? That's fine by me. I definitely think we need to get the release out in order to smoke out the Rust bits and make sure that all works (before we do more of it).

jlebon · 2018-06-28T19:11:53Z

Yeah, basically #1431, #1433, and #1434.

cgwalters · 2018-06-28T19:43:21Z

Yeah, basically #1431, #1433, and #1434.

OK, that's fine by me!

jlebon · 2018-07-04T12:57:18Z

src/daemon/rpmostreed-daemon.c

-  self->ex_stage_deployments = g_key_file_get_boolean (config, EXPERIMENTAL_CONFIG_GROUP,
-                                                       "StageDeployments", NULL);
+  /* The default used to be `false`, so check for the key being present */
+  if (g_key_file_has_key (config, EXPERIMENTAL_CONFIG_GROUP, "StageDeployments", NULL))


Maybe just one release with that, and then we drop support for the key entirely? Or were you thinking of keeping around support for StageDeployments=false? I'm leaning more towards just not supporting turning it off.

Yeah, agree.

In this PR there's a build-time option; @dustymabe was arguing that this should go into rawhide first or something. I dunno if that's really worth it. We have FAHC for automated testing before release.

yeah preferably it would go to rawhide/f29 first.. especially since we have silverblue, IoT, and FAH to consider.

No strong opinions either way. Seems relatively low risk at this point, but I'm fine with delaying f28 for one more release or so. (Maybe at the same time we drop support for the StageDeployments option completely),

cgwalters · 2018-07-05T12:36:47Z

OK, so the livefs thing is harder to fix, basically when we go to push the rollback deployment, the current libostree code prunes the staged deployment.

I could imagine chaging livefs to e.g. install --live or so, then we do it all in one transaction, and we can push the rollback first.

That said, really we want to enhance libostree here to support this, there's no real blockers other than dealing with the complexity in ostree_sysroot_write_deployments_with_options().

cgwalters · 2018-07-13T17:21:25Z

This is getting closer, split out two prep patches:

jlebon · 2018-08-10T19:43:40Z

bot, retest this please

cgwalters · 2018-08-14T13:11:48Z

The thing confusing me is that the tests pass locally; that's why I hadn't made the change to the deployment count check.

cgwalters · 2018-08-20T12:55:26Z

OK, I figured it out - the multitest.py approach has newly provisioned hosts with a rollback deployment, but not subsequent tests.

Nothing calls it today; looks like it was last used in 283b915

So it's easier to debug. This inlines the helper into the only function that uses it.

Staging fixes the `/etc` bug for livefs. There's actually more we could do here around taking advantage of staging for livefs; for example, I think once the livefs is complete, we could just delete the staged deployment. And then we don't need to render on the next boot the live status, etc. Anyways, all that can come in the future. This is prep for enabling staging by default.

We've put a lot of work into staged deployments, it's time to pull the trigger and turn them on by default. This is a key step for enabling `stage` mode automatic updates by default in e.g. Fedora CoreOS/Silverblue. We add a new `--disable-staged` build-time option to flip things back.

cgwalters · 2018-08-20T13:17:39Z

Updated commit message, lifting WIP. Let's do this!

jlebon · 2018-08-20T20:27:58Z

tests/vmcheck/test-meta-staged-layering-relayer.sh

@@ -29,9 +29,9 @@ set -x
 # This test suite enables the libostree staging feature, and executes
 # the layering-relayer tests.


Seems like these comments should be updated now for s/enables/disables?

jlebon · 2018-08-20T20:29:52Z

src/daemon/rpmostreed-daemon.c

-  self->ex_stage_deployments = g_key_file_get_boolean (config, EXPERIMENTAL_CONFIG_GROUP,
-                                                       "StageDeployments", NULL);
+  /* The default used to be `false`, so check for the key being present */
+  if (g_key_file_has_key (config, EXPERIMENTAL_CONFIG_GROUP, "StageDeployments", NULL))


No strong opinions either way. Seems relatively low risk at this point, but I'm fine with delaying f28 for one more release or so. (Maybe at the same time we drop support for the StageDeployments option completely),

jlebon · 2018-08-20T20:31:58Z

Minor comment nit, though not worth a respin. Let's go!
@rh-atomic-bot r+ aa26b20

rh-atomic-bot · 2018-08-20T20:32:04Z

⚡ Test exempted: pull fully rebased and already tested.

So it's easier to debug. This inlines the helper into the only function that uses it. Closes: #1430 Approved by: jlebon

Staging fixes the `/etc` bug for livefs. There's actually more we could do here around taking advantage of staging for livefs; for example, I think once the livefs is complete, we could just delete the staged deployment. And then we don't need to render on the next boot the live status, etc. Anyways, all that can come in the future. This is prep for enabling staging by default. Closes: #1430 Approved by: jlebon

We've put a lot of work into staged deployments, it's time to pull the trigger and turn them on by default. This is a key step for enabling `stage` mode automatic updates by default in e.g. Fedora CoreOS/Silverblue. We add a new `--disable-staged` build-time option to flip things back. Closes: #1430 Approved by: jlebon

jlebon added WIP for-next-release labels Jun 27, 2018

cgwalters self-assigned this Jul 1, 2018

jlebon removed the for-next-release label Jul 4, 2018

jlebon reviewed Jul 4, 2018

View reviewed changes

cgwalters force-pushed the default-staged branch 4 times, most recently from b809f35 to ecb1d27 Compare July 12, 2018 15:56

cgwalters force-pushed the default-staged branch from ecb1d27 to 3fcaed8 Compare July 13, 2018 17:18

cgwalters force-pushed the default-staged branch from 3fcaed8 to e047039 Compare July 30, 2018 23:48

cgwalters mentioned this pull request Jul 30, 2018

livefs: Require deployment staging #1456

Closed

cgwalters force-pushed the default-staged branch 3 times, most recently from 3f2fe91 to fc55736 Compare August 3, 2018 18:44

cgwalters force-pushed the default-staged branch from ba3da8f to 6488058 Compare August 10, 2018 01:30

jlebon force-pushed the default-staged branch from f3bc25a to 2c7a1d0 Compare August 10, 2018 20:04

cgwalters force-pushed the default-staged branch from a46f4a8 to b5f9830 Compare August 19, 2018 23:52

cgwalters added 4 commits August 20, 2018 09:14

tests: Remove dead assert_status_jq

414da27

Nothing calls it today; looks like it was last used in 283b915

tests/vmcheck: Display human-readable status on jq failure

9094557

So it's easier to debug. This inlines the helper into the only function that uses it.

cgwalters force-pushed the default-staged branch from b5f9830 to aa26b20 Compare August 20, 2018 13:17

cgwalters removed the WIP label Aug 20, 2018

cgwalters changed the title ~~WIP: Turn staged deployments on by default~~ Turn staged deployments on by default Aug 20, 2018

jlebon reviewed Aug 20, 2018

View reviewed changes

rh-atomic-bot closed this in 2278b60 Aug 20, 2018

rh-atomic-bot pushed a commit that referenced this pull request Aug 20, 2018

tests/vmcheck: Display human-readable status on jq failure

e1b62d0

So it's easier to debug. This inlines the helper into the only function that uses it. Closes: #1430 Approved by: jlebon

cgwalters mentioned this pull request Sep 10, 2018

initramfs: Fix conflicting information printed by initramfs command #1548

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn staged deployments on by default #1430

Turn staged deployments on by default #1430

cgwalters commented Jun 27, 2018

jlebon commented Jun 27, 2018

cgwalters commented Jun 27, 2018

dustymabe commented Jun 27, 2018

cgwalters commented Jun 27, 2018

jlebon commented Jun 28, 2018

jlebon commented Jun 28, 2018

cgwalters commented Jun 28, 2018

jlebon commented Jun 28, 2018

cgwalters commented Jun 28, 2018

jlebon Jul 4, 2018

cgwalters Jul 5, 2018

cgwalters Aug 20, 2018

dustymabe Aug 20, 2018

jlebon Aug 20, 2018

cgwalters commented Jul 5, 2018

cgwalters commented Jul 13, 2018 •

edited

Loading

jlebon commented Aug 10, 2018

cgwalters commented Aug 14, 2018

cgwalters commented Aug 20, 2018

cgwalters commented Aug 20, 2018

jlebon Aug 20, 2018

jlebon Aug 20, 2018

jlebon commented Aug 20, 2018

rh-atomic-bot commented Aug 20, 2018

		@@ -29,9 +29,9 @@ set -x
		# This test suite enables the libostree staging feature, and executes
		# the layering-relayer tests.

Turn staged deployments on by default #1430

Turn staged deployments on by default #1430

Conversation

cgwalters commented Jun 27, 2018

jlebon commented Jun 27, 2018

cgwalters commented Jun 27, 2018

dustymabe commented Jun 27, 2018

cgwalters commented Jun 27, 2018

jlebon commented Jun 28, 2018

jlebon commented Jun 28, 2018

cgwalters commented Jun 28, 2018

jlebon commented Jun 28, 2018

cgwalters commented Jun 28, 2018

jlebon Jul 4, 2018

Choose a reason for hiding this comment

cgwalters Jul 5, 2018

Choose a reason for hiding this comment

cgwalters Aug 20, 2018

Choose a reason for hiding this comment

dustymabe Aug 20, 2018

Choose a reason for hiding this comment

jlebon Aug 20, 2018

Choose a reason for hiding this comment

cgwalters commented Jul 5, 2018

cgwalters commented Jul 13, 2018 • edited Loading

jlebon commented Aug 10, 2018

cgwalters commented Aug 14, 2018

cgwalters commented Aug 20, 2018

cgwalters commented Aug 20, 2018

jlebon Aug 20, 2018

Choose a reason for hiding this comment

jlebon Aug 20, 2018

Choose a reason for hiding this comment

jlebon commented Aug 20, 2018

rh-atomic-bot commented Aug 20, 2018

cgwalters commented Jul 13, 2018 •

edited

Loading