daemon/syscore: push livefs introspection to Rust #2292
Conversation
|
Nice! I had a side project in this area, just pushed up #2293 to claim the mutex around some of this a bit. |
rust/src/syscore.rs
Outdated
| pub enum RpmOstreeOrigin {} | ||
|
|
||
| extern "C" { | ||
| fn rpmostree_origin_get_live_state( |
There was a problem hiding this comment.
I'm OK with this but we need to be careful because this would mean changing that API C side in the future would result in crashes/corruption on this side.
Let's at least add a comment to both sides warning to change the other; something like this in C:
// WARNING: This prototype is also redefined in Rust, if changing this please also update the Rust side
And here:
// NOTICE: The C header definition is canonical, please update that first then synchronize this
There was a problem hiding this comment.
Ack.
There is another one already bridged (rpmostree_get_repodata_chksum_repr), do you prefer to have all of them in a single place/module in a Rust and a single top-notice?
rust/src/syscore.rs
Outdated
| &mut out_livereplaced, | ||
| ) | ||
| }; | ||
| let in_progress = ffi_new_nullable_string(out_inprogress); |
There was a problem hiding this comment.
I think this might exist today via glib::translate; try something like this:
let in_progress: Option<String> = from_glib_full(out_inprogress);?
See http://gtk-rs.org/docs/src/glib/translate.rs.html#1347-1356
There was a problem hiding this comment.
(And I suspect some of the other ffi_view_ things should just be from_glib_none but at the time I didn't know about everything in GLib Rust bindings)
There was a problem hiding this comment.
Lovely, if that works it will also spare the g_free below. I guess I can also drop the custom ffi_ helper I've introduced.
|
/approve |
This starts bridging parts of the daemon syscore logic to Rust plumbing, moving the livefs detection logic over there as a first consumer. That was the simplest logic available for wiring, and mostly meant as a sanity check.
|
I've switched to the glib-rs methods and re-grouped the C prototypes into its own |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, lucab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This starts bridging parts of the daemon syscore logic to Rust
plumbing, moving the livefs detection logic over there as a first
consumer. That was the simplest logic available for wiring, and
mostly meant as a sanity check.