libpriv/postprocess: work around semanage bug #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the latest semanage code which causes an invocation of `semodule --rebuild-if-modules-changed` to still write a policy even though nothing changed since a full policy build. On FCOS and RHCOS, this bug is triggered as early as `ostree admin deploy` in cosa when creating the disk images. This results in shipping images with a policy diff baked in. Hack around this by immediately rerunning `semodule --rebuild-if-modules-changed` after building the policy. Fixes: openshift/os#1036
cgwalters
approved these changes
Nov 2, 2022
jlebon
commented
Nov 2, 2022
| /* Temporary workaround for https://github.com/openshift/os/issues/1036. */ | ||
| { | ||
| rust::Vec child_argv = { rust::String ("semodule"), rust::String ("-n"), | ||
| rust::String ("--rebuild-if-modules-changed") }; |
There was a problem hiding this comment.
The reason I went with --rebuild-if-modules-changed here instead of the newer --refresh is that the latter is not in f36 and while f36 isn't affected by this bug, I'd like this patch in place ahead of time.
There was a problem hiding this comment.
Also, I didn't add a feature check here for --rebuild-if-modules-changed. I think all the userspaces we care about for the main branch have that patch now.
@cgwalters I think we'll need to backport this to the rhel8 branch, right?
There was a problem hiding this comment.
Oh blah. So we have newer semodule in rhel8 versus f36?? 😢
@cgwalters I think we'll need to backport this to the rhel8 branch, right?
Yeah
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the latest semanage code which causes an invocation of
semodule --rebuild-if-modules-changedto still write a policy even though nothing changed since a full policy build. On FCOS and RHCOS, this bug is triggered as early asostree admin deployin cosa when creating the disk images. This results in shipping images with a policy diff baked in.Hack around this by immediately rerunning
semodule --rebuild-if-modules-changedafter building the policy.Fixes: openshift/os#1036