Add support for IBMCloud/PowerVS images #35
Conversation
|
I haven't followed the PowerVS work closely. Does PowerVS not support sharing traditional VM images? Note that stream-metadata-rust will also need an update. |
correct. it doesn't and so too does IBMCloud in general to my knowledge. so typically during install time, these images are copied over to a PowerVS "instance" where the bootimages are created and the VMs are provisioned. i will also look into changing the rust repo. thanks. |
release/release.go
Outdated
| // PlatformIBMCloud IBMCloud/PowerVS image detail | ||
| type PlatformIBMCloud struct { | ||
| PlatformBase | ||
| Images map[string]IBMCloudObject `json:"images"` |
There was a problem hiding this comment.
keeping this as "Images" here as discussed in: coreos/coreos-assembler#2361 (comment)
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
There was a problem hiding this comment.
Looks good generally.
One other place that should be updated is the docs in https://github.com/coreos/fedora-coreos-tracker/tree/main/metadata/stream.
there is work being done to enable fcos pipeline on ppc64le..once that is done..i want to update a bunch of items related to PowerVS. |
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
|
@bgilbert good for an approval ? |
Today we generate metadata for PowerVS in RHCOS, and we would need this to be updated in the installer in the near future, hence this change. IBMCloud and PowerVS have the same format although as of today there are no IBMCloud objects being generated. The naming here is to use "object" instead of image since these are not traditional bootimages like in other clouds. FCOS is still waiting on ppc64le hardware to have P images generated so could not add any tests related to this.
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
Today we generate metadata for PowerVS in RHCOS, and we would need this to be updated in the installer in the near future, hence this change. IBMCloud and PowerVS have the same format although as of today there are no IBMCloud objects being generated. The naming here is to use "object" instead of image since these are not traditional bootimages like in other clouds.
FCOS is still waiting on ppc64le hardware to have P images generated so could not add any tests related to this.