Document why image_id changes are ignored in etcd/master launch config

coreos · Apr 27, 2017 · d604aa3 · d604aa3
1 parent d925abe
commit d604aa3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/modules/aws/etcd/nodes.tf b/modules/aws/etcd/nodes.tf
@@ -33,6 +33,9 @@ resource "aws_instance" "etcd_node" {
   vpc_security_group_ids = ["${var.sg_ids}"]
 
   lifecycle {
+    # Ignore changes in the AMI which force recreation of the resource. This
+    # avoids accidental deletion of nodes whenever a new CoreOS Release comes
+    # out.
     ignore_changes = ["ami"]
   }
 

diff --git a/modules/aws/master-asg/master.tf b/modules/aws/master-asg/master.tf
@@ -63,7 +63,11 @@ resource "aws_launch_configuration" "master_conf" {
 
   lifecycle {
     create_before_destroy = true
-    ignore_changes        = ["image_id"]
+
+    # Ignore changes in the AMI which force recreation of the resource. This
+    # avoids accidental deletion of nodes whenever a new CoreOS Release comes
+    # out.
+    ignore_changes = ["image_id"]
   }
 
   root_block_device {

diff --git a/modules/aws/worker-asg/worker.tf b/modules/aws/worker-asg/worker.tf
@@ -33,10 +33,11 @@ resource "aws_launch_configuration" "worker_conf" {
 
   lifecycle {
     create_before_destroy = true
+
     # Ignore changes in the AMI which force recreation of the resource. This
     # avoids accidental deletion of nodes whenever a new CoreOS Release comes
     # out.
-    ignore_changes        = ["image_id"]
+    ignore_changes = ["image_id"]
   }
 
   root_block_device {