This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
Update to TerraForm v0.9.4 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsomesan
force-pushed
the
tf09-ignition-datasource
branch
3 times, most recently
from
374ec3d
to
bdbbc8f
Compare
Quentin-M
reviewed
Apr 26, 2017
| ] | ||
|
|
||
| systemd = [ | ||
| <<<<<<< HEAD |
Quentin-M
reviewed
Apr 26, 2017
| "${data.ignition_systemd_unit.locksmithd.id}", | ||
| "${data.ignition_systemd_unit.kubelet-master.id}", | ||
| "${data.ignition_systemd_unit.tectonic.id}", | ||
| >>>>>>> Convert ignition resources to datasources. Prepare for moving to TF 0.9 |
|
Hey! @alexsomesan Is this PR still good? I want to re-use it alongside with a v0.9.4 bump. |
alexsomesan
force-pushed
the
tf09-ignition-datasource
branch
from
bdbbc8f
to
876915b
Compare
|
Sorry about that forgotten conflict :) |
|
Thanks for the update! 👍 👍 👍 |
|
Have fun! ;)
going to bed now...
…On Thu, Apr 27, 2017 at 2:00 AM, Quentin Machu ***@***.***> wrote:
Thanks for the update! 👍 👍 👍
Let me update some other stuff in there!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABC-m1_BhmuNzjiJhivpbZp8yDqvmmfgks5rz9qQgaJpZM4M6ZbX>
.
|
Quentin-M
force-pushed
the
tf09-ignition-datasource
branch
from
c571510
to
34f9133
Compare
Quentin-M
changed the title
they are now included in TerraForm upstream as of v0.9.4.
|
Successfully deployed a cluster with a clean build of this PR and TerraForm v0.9.4. Good to merge! |
Quentin-M
force-pushed
the
tf09-ignition-datasource
branch
from
34f9133
to
029cf8e
Compare
|
cc @derekparker for the builder image bump. (1.7 after this PR gets merged) |
|
Tests passed (despite quota issue), also deployed clusters manually. |
dghubble
approved these changes
Apr 27, 2017
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts ignition resources to data-sources.
This is a first step in preparation of adopting Terraform 0.9.
We CANNOT MOVE yet because of a known issue with ignition provider that wasn't resolved yet.
Tried to do a build with these changes. The first attempt fails with the error described in the issue below.
A second attempt builds successfully.
Issue tracker here: hashicorp/terraform#11518
@Quentin-M @s-urbaniak