-
Notifications
You must be signed in to change notification settings - Fork 266
Update to TerraForm v0.9.4 #219
Update to TerraForm v0.9.4 #219
Conversation
374ec3d
to
bdbbc8f
Compare
] | ||
|
||
systemd = [ | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
"${data.ignition_systemd_unit.locksmithd.id}", | ||
"${data.ignition_systemd_unit.kubelet-master.id}", | ||
"${data.ignition_systemd_unit.tectonic.id}", | ||
>>>>>>> Convert ignition resources to datasources. Prepare for moving to TF 0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Hey! @alexsomesan Is this PR still good? I want to re-use it alongside with a v0.9.4 bump. |
bdbbc8f
to
876915b
Compare
Sorry about that forgotten conflict :) |
Thanks for the update! 👍 👍 👍 |
Have fun! ;)
going to bed now...
…On Thu, Apr 27, 2017 at 2:00 AM, Quentin Machu ***@***.***> wrote:
Thanks for the update! 👍 👍 👍
Let me update some other stuff in there!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABC-m1_BhmuNzjiJhivpbZp8yDqvmmfgks5rz9qQgaJpZM4M6ZbX>
.
|
c571510
to
34f9133
Compare
they are now included in TerraForm upstream as of v0.9.4.
Successfully deployed a cluster with a clean build of this PR and TerraForm v0.9.4. Good to merge! |
34f9133
to
029cf8e
Compare
cc @derekparker for the builder image bump. (1.7 after this PR gets merged) |
Tests passed (despite quota issue), also deployed clusters manually. |
Thanks! |
Converts ignition resources to data-sources.
This is a first step in preparation of adopting Terraform 0.9.
We CANNOT MOVE yet because of a known issue with ignition provider that wasn't resolved yet.
Tried to do a build with these changes. The first attempt fails with the error described in the issue below.
A second attempt builds successfully.
Issue tracker here: hashicorp/terraform#11518
@Quentin-M @s-urbaniak