Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled ',' (comma) in StringWithMacro expression #37

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

airween
Copy link
Contributor

@airween airween commented Oct 19, 2022

This is another form of #36.

Enabled , (comma) character in some cases (eg. by logdata). With this, the below form is allowed:

logdata:'blocked foo, param_with_underscore=%{TX:1}, value_with_underscore=%{TX:2}'

Perhaps we have to review the allowed arguments type at the actions, I think there are more actions which allow this in the engine(s) than here. And there is an another used solution, eg.

   125      'msg:' msg=MessageValue | ...
   ...
   216  MessageValue: "'" /((\\')|[^\'])*/ "'";

which - may be - we can use.

@fzipi fzipi merged commit a08bc51 into coreruleset:master Oct 20, 2022
@fzipi fzipi mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants