Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow ';' in PathNameValue; Make XML collection less strict #76

Merged
merged 2 commits into from
May 29, 2024

Conversation

airween
Copy link
Contributor

@airween airween commented May 29, 2024

There are two modifications which fix the phpbb plugin issue:

  • PathNameValue must have been extended, because it's used to reduce as @beginsWith for eg., and the ; needed
  • XML is represented as SpecialCollection, and it was too strict: it allowed only the collection with key, but the exclusion contains only the collection name (XML)

The parser became less strict with these modifications.

CRS (the current) is still parsed as well.

@airween
Copy link
Contributor Author

airween commented May 29, 2024

Sorry, I didn't realize that there were an uncommitted modification: REQUEST_BODY_LENGTH and REQUEST_BODY variables were reordered, because the first one (body length) is longer and the other is a real subset of this, so the longer one should be first.

@fzipi fzipi merged commit 92d156c into coreruleset:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants