Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more types checks -- NOT PASSING #10

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add more types checks -- NOT PASSING #10

wants to merge 17 commits into from

Conversation

corinagum
Copy link
Owner

@corinagum corinagum commented May 24, 2021 •
edited
Loading

Note: createDirectLine and createStore are imported from component, not bundle. Still need to be tested from bundle

Failing:

  • <SendTextBox>
  • add directLine prop in <ReactWebChat>
  • add store prop in <ReactWebChat>

@corinagum corinagum requested a review from compulim as a code owner May 24, 2021 23:13
dependabot bot and others added 11 commits June 1, 2021 12:05
@dependabot
Bump browserslist from 4.14.6 to 4.16.6 in /packages/core (microsoft#…
e83d886 
…3911)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.6 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.14.6...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump browserslist from 4.16.3 to 4.16.6 in /packages/embed (microsoft…
3619b0f 
…#3916)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.3 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.16.3...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump ws from 7.4.4 to 7.4.6 in /packages/core (microsoft#3919)
24535a8 
Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.4...7.4.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump ws from 7.4.5 to 7.4.6 in /packages/test/page-object (microsoft#…
4af4fbf 
…3920)

Bumps [ws](https://github.com/websockets/ws) from 7.4.5 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.5...7.4.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump ws from 7.4.5 to 7.4.6 in /packages/test/harness (microsoft#3921)
ebcd479 
Bumps [ws](https://github.com/websockets/ws) from 7.4.5 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.5...7.4.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump ws from 7.4.4 to 7.4.6 in /packages/embed (microsoft#3922)
3f3f9ba 
Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.4...7.4.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@compulim
Bump deps and remove remark and strip-markdown (microsoft#3917)
3d75dee 
* Bump deps

* Go back to v1

* Remove remark and strip-markdown

* Revert to v1

* Revert to v1

* Revert to v1

* Supports summary field

* Ignore summary field

* Strip Markdown from HTML

* Add speak field not present

* Update strip Markdown

* Narrate empty text field

* Use different text computation for HTML/Markdown

* Clean up

* Update with samples

* More inline elements

* Clean up

* MessageBack must not be Markdown

* Lockdown performance

* Add snapshots

* Fix MessageBack

* Remove renderMarkdownAsHTML

* Fix ESLint

* Assume plain text if renderMarkdown is null

* Compute text alternatives using alt field

* Change to webchat:fallback-text field

* Bump to [email protected]

* Typo

* Update entry

* Typo

* Update entry

* Link to issue

* Undo package*.json for core/embed

* Move allTextContents into testHelpers

* Add @param

* Apply PR suggestions

* Update text
@compulim @corinagum
Add scrollToEndButtonBehavior style options (microsoft#3926)
79b337e 
* Add scrollToEndButtonBehavior style option

* Rename newMessagesButtonFontSize to scrollToEndButtonFontSize

* Rename "newMessageButton" to "scrollToEndButton"

* Add entry

* Verbiage

* Update ESLint for TypeScript

* Added details

* Update entry

* Typo

* Add more JSDocs

* Fix test

* Clean up deprecated options

* Clean up

* Apply suggestions from code review

Co-authored-by: Corina <[email protected]>

* Clean up typings

* Apply PR suggestions

* Apply PR suggestions

* Apply PR suggestions

* Apply suggestions from code review

Co-authored-by: Corina <[email protected]>

* Rename snapshots

Co-authored-by: Corina <[email protected]>
@corinagum @compulim
Add more types checks -- NOT PASSING
e08395e
@compulim
Add typings
28e05ae
@compulim
Typing the hooks
4425dc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim Awaiting requested review from compulim compulim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corinagum @compulim