Use esbuild to bundle firebase functions rewritten in TypeScipt

[SamChou19815]

Summary

This PR adds a build step to firebase functions instead of using the old approach of using JS only without any build step.

I decided to use esbuild to bundle it mostly for its speed and ease of configuration. You can also use webpack for bundling, but that requires a lot of config.
In addition, I decided to bundle instead of simply transpile since I have future plan to organize our repo into workspaces (see npm workspaces (v7 only) or yarn workspaces). Unfortunately, firebase tools do not work well with with these workspaces, so we have to bundle the code into a single, self-contained js file without any dependencies, so that firebase tools will not look into node_modules. The bundled code is put inside functions/deployment-template with a package.json without dependencies.

Test Plan

cd functions && npm run deploy

Function should be invoked fine (unfortunately I don't have access to the google cloud project)

[dti-github-bot]

[diff-counting] Significant lines: 33.

[github-actions]

Visit the preview URL for this PR (updated for commit ad37f77):

https://cornelldti-courseplan-dev--pr539-esbuild-bundle-funct-ha8f04cr.web.app

_{(expires Wed, 20 Oct 2021 23:03:27 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[hahnbeelee]

hmm looks like i don't have permissions either. @willespencer can you review this?

[SamChou19815]

hmm looks like i don't have permissions either. @willespencer can you review this?

@hahnbeelee try to run firebase use default to switch to staging site. Here you are trying to deploy to prod.

[willespencer]

When I run the deploy command, I get the following error? Not sure what could be causing this

[SamChou19815]

When I run the deploy command, I get the following error? Not sure what could be causing this

Looks like a windows issue. Are you running this in WSL or normal terminals?

[hahnbeelee]

OK, so I was able to run npm run deploy but when I tried invoking TrackUsers here I got this error:

[hahnbeelee]

More info here: https://console.firebase.google.com/u/0/project/cornelldti-courseplan-dev/functions/logs?search=&severity=DEBUG

[SamChou19815]

OK, so I was able to run npm run deploy but when I tried invoking TrackUsers here I got this error:

I might know what's happening. I think bumping firebase-admin might help. It's issue with esbuild is only fixed recently: googleapis/nodejs-firestore#1493

[SamChou19815]

@hahnbeelee I bumped the dependencies and deployed it, but still could not test. Can you help to run it?

[hahnbeelee]

Successfully deployed! :)