Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] generateToolState metadataProvider 'generalImageModule' using OHIF #847

Closed
jlopes90 opened this issue Oct 24, 2023 · 1 comment · Fixed by #1165
Closed

[Bug] generateToolState metadataProvider 'generalImageModule' using OHIF #847

jlopes90 opened this issue Oct 24, 2023 · 1 comment · Fixed by #1165

Comments

@jlopes90
Copy link
Contributor

jlopes90 commented Oct 24, 2023

// Pre-compute the sop UID to imageId index map so that in the for loop
// we don't have to call metadataProvider.get() for each imageId over
// and over again.
const sopUIDImageIdIndexMap = imageIds.reduce((acc, imageId) => {
const { sopInstanceUid } = metadataProvider.get(
"generalImageModule",
imageId
);
acc[sopInstanceUid] = imageId;
return acc;
}, {});

generalImageModule is made by OHIF.

Is it necessary to create generalImageModule or is it to correct generalImageModule to sopCommonModule or something like that?

@sedghi
Copy link
Member

sedghi commented Jan 10, 2024

We should add it to DicomImageLoader if it lives only in OHIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants