Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MetaDataProvider): Update metadata provider #1165

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

jlopes90
Copy link
Contributor

@jlopes90 jlopes90 commented Mar 20, 2024

Context

Fixes #847

The added MetadataModules are:

generalImageModule
generalStudyModule
instanceModule
overlayPlaneModule
patientModule
petImageModule
petIsotopeModule
petSeriesModule

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 3c0d833
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/66043847ee72680008260616
😎 Deploy Preview https://deploy-preview-1165--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jlopes90
Copy link
Contributor Author

jlopes90 commented Mar 21, 2024

Are all first letter tags decapitalized or do you prefer capital letters or original tags?

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this PR, thanks. Please see my comments

@jlopes90
Copy link
Contributor Author

@sedghi up

@jlopes90 jlopes90 requested a review from sedghi March 29, 2024 17:09
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sedghi sedghi merged commit df5583d into cornerstonejs:main Mar 29, 2024
9 checks passed
@jlopes90 jlopes90 deleted the feat-metadata-provider branch April 1, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] generateToolState metadataProvider 'generalImageModule' using OHIF
2 participants