pythongh-123358: Update LOAD_DEREF to use stackref and atomic incref

corona10 · Sep 24, 2024 · beaa325 · beaa325
1 parent 20ccda0
commit beaa325
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 19 deletions.
diff --git a/Include/internal/pycore_cell.h b/Include/internal/pycore_cell.h
@@ -2,6 +2,7 @@
 #define Py_INTERNAL_CELL_H
 
 #include "pycore_critical_section.h"
+#include "pycore_object.h"
 
 #ifdef __cplusplus
 extern "C" {
@@ -42,6 +43,27 @@ PyCell_GetRef(PyCellObject *cell)
     return res;
 }
 
+static inline void
+_PyCell_GetStackRef(PyCellObject *cell, _PyStackRef *value_addr)
+{
+    PyObject *value = _Py_TryXGetRef(&cell->ob_ref);
+    if (value != NULL) {
+        if (_Py_IsImmortal(value) || _PyObject_HasDeferredRefcount(value)) {
+            *value_addr =  (_PyStackRef){ .bits = (uintptr_t)value | Py_TAG_DEFERRED };
+            return;
+        }
+        *value_addr = PyStackRef_FromPyObjectSteal(value);
+        return;
+    }
+    // fallback
+    value = PyCell_GetRef(cell);
+    if (value == NULL) {
+        *value_addr = PyStackRef_NULL;
+        return;
+    }
+    *value_addr = PyStackRef_FromPyObjectSteal(value);
+}
+
 #ifdef __cplusplus
 }
 #endif

diff --git a/Include/internal/pycore_opcode_metadata.h b/Include/internal/pycore_opcode_metadata.h
diff --git a/Include/internal/pycore_uop_metadata.h b/Include/internal/pycore_uop_metadata.h
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -1648,14 +1648,13 @@ dummy_func(
             value = PyStackRef_FromPyObjectSteal(value_o);
         }
 
-        inst(LOAD_DEREF, ( -- value)) {
+        inst(LOAD_DEREF, ( -- value[1])) {
             PyCellObject *cell = (PyCellObject *)PyStackRef_AsPyObjectBorrow(GETLOCAL(oparg));
-            PyObject *value_o = PyCell_GetRef(cell);
-            if (value_o == NULL) {
+            _PyCell_GetStackRef(cell, value);
+            if (PyStackRef_IsNull(*value)) {
                 _PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
                 ERROR_IF(true, error);
             }
-            value = PyStackRef_FromPyObjectSteal(value_o);
         }
 
         inst(STORE_DEREF, (v --)) {

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h