Defer cancel on timeout for heartbeat

Signed-off-by: Anna Tran <[email protected]>
cortexproject · Sep 17, 2024 · c6a3ca9 · c6a3ca9
1 parent 3041b3c
commit c6a3ca9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/ring/lifecycler.go b/pkg/ring/lifecycler.go
@@ -543,8 +543,9 @@ func (i *Lifecycler) loop(ctx context.Context) error {
 
 func (i *Lifecycler) heartbeat(ctx context.Context) {
 	i.lifecyclerMetrics.consulHeartbeats.Inc()
-	ctx, _ = context.WithTimeout(ctx, i.cfg.HeartbeatPeriod)
-	if err := i.updateConsul(context.Background()); err != nil {
+	ctx, cancel := context.WithTimeout(ctx, i.cfg.HeartbeatPeriod)
+	defer cancel()
+	if err := i.updateConsul(ctx); err != nil {
 		level.Error(i.logger).Log("msg", "failed to write to the KV store, sleeping", "ring", i.RingName, "err", err)
 	}
 }