Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce http config settings in Azure storage #4581

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Introduce http config settings in Azure storage #4581

merged 3 commits into from
Dec 13, 2021

Commits on Dec 8, 2021

  1. Introduce http config settings in Azure storage

    Cortex v1.11.0 included thanos-io/thanos#3970, which added configuration
    options to Azure's http client and transport, replacing usage of
    `http.DefaultClient`. Unfortunately since Cortex was not setting this
    config, Cortex implicitly switched from `http.DefaultClient` to all
    empty values (e.g. `MaxIdleConns: 0` rather than 100).
    
    Introduce `http` config settings to Azure storage. This motivated moving
    `s3.HTTPConfig` into a new `pkg/storage/bucket/config` package, to allow
    `azure` and `s3` to share it.
    
    Also update the instructions for running the website to include
    installing `embedmd`.
    
    Signed-off-by: Andrew Seigner <[email protected]>
    siggy committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    fef46f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. feedback: config.HTTP -> http.Config

    also back out changelog cleanup
    
    Signed-off-by: Andrew Seigner <[email protected]>
    siggy committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    24576ee View commit details
    Browse the repository at this point in the history
  2. Back out accidental changelog addition

    Signed-off-by: Andrew Seigner <[email protected]>
    siggy committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    d15911c View commit details
    Browse the repository at this point in the history