Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info field to query response #6207

Merged

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Sep 11, 2024

What this PR does:
From Prometheus 2.54.0, an info field is added to store query issues. So, adding it to the Cortex for Prometheus compatibility is also necessary.
Which issue(s) this PR fixes:
Fixes #6117

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212
Copy link
Contributor Author

@rapphil @yeya24
Could you please take a look?

pkg/ruler/frontend_client.go Outdated Show resolved Hide resolved
pkg/ruler/frontend_decoder.go Outdated Show resolved Hide resolved
@SungJin1212 SungJin1212 force-pushed the Add-info-field-to-query-response branch 4 times, most recently from 71ba8eb to 1f76efe Compare September 15, 2024 09:13
@SungJin1212 SungJin1212 force-pushed the Add-info-field-to-query-response branch from 1f76efe to d7a2e69 Compare September 16, 2024 04:20
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yeya24 yeya24 merged commit 0f848d8 into cortexproject:master Sep 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to the Info field in the body of query API responses
2 participants