Improve validation metrics for discarded samples and exemplars #6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
friedrichg
approved these changes
Sep 18, 2024
CharlieTLe
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Should we create a new metric for discarded histograms? Perhaps add a new label to this metric called type like we do in
cortex/pkg/distributor/distributor.go
Line 636 in c6048fa
|
@CharlieTLe I think we can add that but it will be a big change. Probably all the DiscardedSamples code we need to separate float and native histogram samples. We can create a separate issue to discuss and track that. |
Signed-off-by: Ben Ye <[email protected]>
|
@friedrichg Updated unit tests |
CharlieTLe
reviewed
Sep 19, 2024
pkg/distributor/distributor_test.go
Outdated
| require.Equal(t, testutil.ToFloat64(ds[0].validateMetrics.DiscardedSamples.WithLabelValues(validation.DroppedByRelabelConfiguration, id)), float64(1)) | ||
| require.Equal(t, testutil.ToFloat64(ds[0].validateMetrics.DiscardedExemplars.WithLabelValues(validation.DroppedByRelabelConfiguration, id)), float64(2)) | ||
| require.Equal(t, testutil.ToFloat64(ds[0].receivedSamples.WithLabelValues(id, "float")), float64(1)) | ||
| require.Equal(t, testutil.ToFloat64(ds[0].receivedSamples.WithLabelValues(id, "histogram")), float64(0)) |
There was a problem hiding this comment.
Should we test ingesting a native histogram and see it be discarded?
There was a problem hiding this comment.
Updated in latest commit
Signed-off-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In Distributor's validation logic, we currently update
DiscardedSamplesmetric when there is no label.However, it doesn't count native histogram samples, only normal samples. It doesn't track discarded exemplars or track it in a wrong way https://github.com/cortexproject/cortex/blob/master/pkg/distributor/distributor.go#L898
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]