Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase LivenessCheck timeout #6227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajagopalanand
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Anand Rajagopal <[email protected]>
@rajagopalanand
Copy link
Contributor Author

rajagopalanand commented Sep 23, 2024

Screenshot 2024-09-22 at 8 32 01 PM

histogram_quantile(0.99, sum(rate(cortex_ruler_client_request_duration_seconds_bucket{operation="/ruler.Ruler/LivenessCheck"}[2m])) by (le,instance))

Depending on the environment, the LivenessCheck could take longer than the original 100 ms like the graph above shows. I want to set the timeout to 1s because it is not configurable

@rajagopalanand rajagopalanand marked this pull request as ready for review September 23, 2024 01:37
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it configurable then?
There might be cases where 1s timeout couldn't work

@rajagopalanand
Copy link
Contributor Author

Let's make it configurable then? There might be cases where 1s timeout couldn't work

Wondering what would be the best way to do this. There is already a Remote timeout (remote_timeout) under ruler client which is set to 2 minutes. If I introduce a config specifically for LivenessCheck, I was thinking it should also go under ruler client but then it might be confusing to have a generic deadline (remote_timeout) and a specific one for LivenessCheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants