Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.3.x feature delete page icon #1379

Merged
merged 1 commit into from
Oct 24, 2023
Merged

2023.3.x feature delete page icon #1379

merged 1 commit into from
Oct 24, 2023

Conversation

katrinDY
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@katrinDY katrinDY added enhancement New feature or request backend Backend server changes (GO) frontend Frontend code changes (Javascript, Typescript, Vue.js) labels Aug 21, 2023
@katrinDY katrinDY added this to the 2023.3.6 milestone Aug 21, 2023
@katrinDY katrinDY linked an issue Aug 21, 2023 that may be closed by this pull request
Add an option to remove an icon once it has been added #1217
Closed
@Fajfa Fajfa force-pushed the 2023.3.x branch 2 times, most recently from 77f8765 to 7254628 Compare August 25, 2023 09:26
@katrinDY katrinDY modified the milestones: 2023.3.6, 2023.9.0 Sep 4, 2023
@KinyaElGrande KinyaElGrande force-pushed the 2023.3.x-feature-delete-page-icon branch from 8744d56 to ddd2799 Compare October 16, 2023 10:43
@katrinDY katrinDY force-pushed the 2023.3.x-feature-delete-page-icon branch 2 times, most recently from afa8413 to 8621be1 Compare October 17, 2023 09:50
@katrinDY katrinDY changed the base branch from 2023.3.x to 2023.9.x October 17, 2023 09:51
Fajfa
Fajfa requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it more obvious what the delete button does and separate it from save and close/cancel.
Also make sure that the c-input-confirm is disabled/processing when deleting icon

@katrinDY katrinDY requested a review from Fajfa October 18, 2023 07:41
@katrinDY katrinDY force-pushed the 2023.3.x-feature-delete-page-icon branch from 6e87e9e to eba6ef5 Compare October 18, 2023 11:17
@Fajfa Fajfa force-pushed the 2023.3.x-feature-delete-page-icon branch from eba6ef5 to a97ef7c Compare October 19, 2023 11:31
@katrinDY katrinDY force-pushed the 2023.3.x-feature-delete-page-icon branch from a97ef7c to cb5304a Compare October 24, 2023 09:34
@katrinDY katrinDY force-pushed the 2023.3.x-feature-delete-page-icon branch from cb5304a to 82636ae Compare October 24, 2023 09:34
@katrinDY katrinDY merged commit 82636ae into 2023.9.x Oct 24, 2023
1 check passed
@katrinDY katrinDY deleted the 2023.3.x-feature-delete-page-icon branch October 24, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Fajfa approved these changes

Assignees

@KinyaElGrande KinyaElGrande

@katrinDY katrinDY

Labels
backend Backend server changes (GO) enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js)
Projects
None yet
Milestone
2023.9.0
Development

Successfully merging this pull request may close these issues.

Add an option to remove an icon once it has been added
3 participants
@katrinDY @Fajfa @KinyaElGrande