Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spinner to c input confirm and apply necessary changes to all webapps #1464

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add spinner to c input confirm and apply necessary changes to all webapps #1464

merged 1 commit into from
Oct 24, 2023

Conversation

katrinDY
Copy link
Contributor

@katrinDY katrinDY commented Oct 3, 2023

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@katrinDY katrinDY requested a review from Fajfa October 3, 2023 07:48
@katrinDY katrinDY self-assigned this Oct 3, 2023
@katrinDY katrinDY added enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) labels Oct 3, 2023
@katrinDY katrinDY added this to the 2023.9.0 milestone Oct 3, 2023
@katrinDY katrinDY linked an issue Oct 3, 2023 that may be closed by this pull request
Add a reusable processing button component and apply it to appropriate places #1361
Closed
12 tasks
@katrinDY katrinDY force-pushed the 2023.9.x-feature-add-spinner-to-c-input-confirm branch 5 times, most recently from 7410426 to e68ebeb Compare October 5, 2023 11:41
Fajfa
Fajfa requested changes Oct 6, 2023
View reviewed changes
lib/vue/src/components/input/CInputConfirm.vue Outdated Show resolved Hide resolved
lib/vue/src/components/input/CInputConfirm.vue Outdated Show resolved Hide resolved
client/web/admin/src/components/Apigw/Profiler/CProfilerRouteHits.vue Outdated Show resolved Hide resolved
client/web/compose/src/views/Admin/Pages/Edit.vue Outdated Show resolved Hide resolved
client/web/privacy/src/components/Common/EditorToolbar.vue Outdated Show resolved Hide resolved
lib/vue/src/components/input/CInputConfirm.vue Show resolved Hide resolved
@katrinDY katrinDY force-pushed the 2023.9.x-feature-add-spinner-to-c-input-confirm branch from fa7b39c to d93a8f6 Compare October 20, 2023 09:00
@katrinDY katrinDY force-pushed the 2023.9.x-feature-add-spinner-to-c-input-confirm branch from d93a8f6 to 0f1af05 Compare October 24, 2023 10:15
@katrinDY katrinDY merged commit 0f1af05 into 2023.9.x Oct 24, 2023
1 check passed
@katrinDY katrinDY deleted the 2023.9.x-feature-add-spinner-to-c-input-confirm branch October 24, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Fajfa approved these changes

Assignees

@katrinDY katrinDY

Labels
enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js)
Projects
None yet
Milestone
2023.9.0
Development

Successfully merging this pull request may close these issues.

Add a reusable processing button component and apply it to appropriate places
2 participants
@katrinDY @Fajfa