Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an horizontal mode for recordeditor fields #1864

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add an horizontal mode for recordeditor fields #1864

merged 2 commits into from
Sep 26, 2024

Conversation

EmmyMay
Copy link
Contributor

@EmmyMay EmmyMay commented Jul 17, 2024

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@Fajfa Fajfa linked an issue Jul 18, 2024 that may be closed by this pull request
Option to display Fields horizontally in a Record block not just vertically #1393
Closed
@EmmyMay EmmyMay force-pushed the 2024.3.x-feature-add-new-record-field-layout branch from 481f092 to 06ff8b2 Compare August 23, 2024 14:08
Fajfa
Fajfa requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix padding on default edit (test all combinations aswell).
Prevent horizontal being on when no wrap is on.

@EmmyMay EmmyMay force-pushed the 2024.3.x-feature-add-new-record-field-layout branch from 06ff8b2 to 4b875de Compare August 29, 2024 20:05
@EmmyMay @Fajfa
Standardize list inputs
a60c65b 
***Refactor field row view component in module***
***Add small responsive design to unique values table***
***Update system fields table in module edit view
@EmmyMay @Fajfa
Add record block layout options (wrap, no wrap)
3c55de3
@Fajfa Fajfa force-pushed the 2024.3.x-feature-add-new-record-field-layout branch from f7d1ac4 to 3c55de3 Compare September 26, 2024 11:31
@Fajfa Fajfa merged commit 3c55de3 into 2024.3.x Sep 26, 2024
11 checks passed
@Fajfa Fajfa deleted the 2024.3.x-feature-add-new-record-field-layout branch September 26, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Fajfa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to display Fields horizontally in a Record block not just vertically
2 participants
@EmmyMay @Fajfa