feat(dri-1308): add unitless unit

corva-ai · Aug 21, 2024 · 314cbd6 · 314cbd6
1 parent bb1fed4
commit 314cbd6
Show file tree

Hide file tree

Showing 6 changed files with 52 additions and 7 deletions.
diff --git a/src/corva_unit_converter/converter.py b/src/corva_unit_converter/converter.py
@@ -35,7 +35,8 @@
     "volume_concentration": definitions.volume_concentration.rule,
     "volume_flow_rate": definitions.volume_flow_rate.rule,
     "voltage": definitions.voltage.rule,
-    "viscosity": definitions.viscosity.rule
+    "viscosity": definitions.viscosity.rule,
+    "unitless": definitions.unitless.rule,
 }
 
 

diff --git a/src/corva_unit_converter/definitions/__init__.py b/src/corva_unit_converter/definitions/__init__.py
@@ -31,6 +31,7 @@
     temperature,
     time,
     torque,
+    unitless,
     viscosity,
     voltage,
     volume_concentration,
@@ -70,6 +71,7 @@
     "temperature",
     "time",
     "torque",
+    "unitless",
     "voltage",
     "volume_concentration",
     "volume_flow_rate",

diff --git a/src/corva_unit_converter/definitions/unitless.py b/src/corva_unit_converter/definitions/unitless.py
@@ -0,0 +1,30 @@
+metric = imperial = {
+   "unitless": {
+      "name": {
+         "singular": "unitless",
+         "plural": "unitless",
+         "display": "unitless"
+      },
+      "to_anchor": 1,
+      "aliases": [
+        "On/Off",
+        "None",
+        "EUC"
+      ]
+   },
+}
+
+rule = {
+   "metric": metric,
+   "imperial": imperial,
+   "_anchors": {
+      "metric": {
+         "unit": "unitless",
+         "ratio": 1
+      },
+      "imperial": {
+         "unit": "unitless",
+         "ratio": 1
+      }
+   }
+}
diff --git a/src/version.py b/src/version.py
@@ -1 +1 @@
-VERSION = "0.5.0"
+VERSION = "0.6.0"
diff --git a/tests/test_converter.py b/tests/test_converter.py
@@ -11,11 +11,12 @@ def test_get_measures_returns_correct_keys():
     expected_keys = [
         "acoustic_slowness", "angle", "angle_per_length", "angular_velocity",
         "area", "density", "energy", "force", "gas_concentration",
-        "gas_volume", "gamma_radiation", "inverse_pressure", "length", "length_per_angle",
-        "mass", "mass_flow_rate", "mpl", "porosity", "power", "pressure",
-        "pressure_gradient", "proportion", "revolution_per_volume", "speed",
-        "strokes_rate", "temperature", "time", "torque",
-        "volume_concentration", "volume_flow_rate", "viscosity", "voltage"
+        "gas_volume", "gamma_radiation", "inverse_pressure", "length",
+        "length_per_angle", "mass", "mass_flow_rate", "mpl", "porosity",
+        "power", "pressure", "pressure_gradient", "proportion",
+        "revolution_per_volume", "speed", "strokes_rate", "temperature",
+        "time", "torque", "volume_concentration", "volume_flow_rate",
+        "viscosity", "voltage", "unitless"
     ]
 
     assert sorted(result) == sorted(expected_keys)

diff --git a/tests/test_unitless.py b/tests/test_unitless.py
@@ -0,0 +1,11 @@
+from .utils import convert_units
+
+# test cases
+cases = [
+    {"from": "unitless", "amount": 1, "to": "unitless", "expected": 1,
+     "measure": 'unitless'}
+]
+
+
+def test():
+    convert_units(cases)