IP Maturity Matrix review #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongeorge1
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
With the "How to" documentation, you've given it a "1" to indicate that common scenarios are covered. However, not all common scenarios are covered - there's no mention of the code that allows you to set up IConfiguration using a test file.
Also, whilst we haven't really established a "normal" yet for docs, other projects have them in a "docs" folder alongside "Solutions". I don't feel particularly strongly about it right now, as we don't have any kind of standard, but I suspect they will need to be moved out of README.md as we add other types of documentation anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50