-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4 Release #398
Open
mwadams
wants to merge
218
commits into
main
Choose a base branch
from
v4-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V4 Release #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We emit compilable code for the Type validation and pass the specs!
- Fixed bug: core type constructor
- Refactored the common format mapping code into helper classes - Added a `Keywords()` extension method that caches the actual keywords available on the type.
- Updated project dependencies - Moved C# code generation code into the correct folder
- allows us to ignore keywords for the purpose of determining built-in types etc
- number partial - numeric type validation handler
- Added additional keywords for OpenApi30 dialect.
Updated nuget package descriptions.
- still need to implement SetProperty() and RemoveProperty() overloads, plus the __CorvusObjectHelpers.
Do not pack the Sandbox.SourceGenerator.
…32 properties or items.
* Fixed bug: line spaces no longer being applied. * Failing test added. * Fixed bug #440 De-duplicated documentation when the property type is not reducible. * Include all unreduced type short documentation.
…ed for sibling-hiding keywords
Code Coverage Summary Report - Linux (net8.0)Summary
CoverageCorvus.Json.CodeGeneration - 77.2%
Corvus.Json.CodeGeneration.201909 - 87%
Corvus.Json.CodeGeneration.202012 - 86.3%
Corvus.Json.CodeGeneration.4 - 85.2%
Corvus.Json.CodeGeneration.6 - 87.6%
Corvus.Json.CodeGeneration.7 - 89%
Corvus.Json.CodeGeneration.CSharp - 90.6%
Corvus.Json.CodeGeneration.OpenApi30 - 79.6%
Corvus.Json.ExtendedTypes - 61.1%
Corvus.Json.JsonReference - 61.4%
Corvus.Json.Patch - 19.9%
Corvus.Json.Specs - 55.2%
|
Code Coverage Summary Report - Windows (net481)Summary
CoverageCorvus.Json.CodeGeneration - 79.4%
Corvus.Json.CodeGeneration.201909 - 87%
Corvus.Json.CodeGeneration.202012 - 86.3%
Corvus.Json.CodeGeneration.4 - 85.2%
Corvus.Json.CodeGeneration.6 - 87.6%
Corvus.Json.CodeGeneration.7 - 89%
Corvus.Json.CodeGeneration.CSharp - 90.5%
Corvus.Json.CodeGeneration.OpenApi30 - 79.6%
Corvus.Json.ExtendedTypes - 65.4%
Corvus.Json.JsonReference - 63.5%
Corvus.Json.Patch - 21.7%
Corvus.Json.Specs - 55.9%
IndexRange - 28%
|
Code Coverage Summary Report - Windows (net8.0)Summary
CoverageCorvus.Json.CodeGeneration - 77.2%
Corvus.Json.CodeGeneration.201909 - 87%
Corvus.Json.CodeGeneration.202012 - 86.3%
Corvus.Json.CodeGeneration.4 - 85.2%
Corvus.Json.CodeGeneration.6 - 87.6%
Corvus.Json.CodeGeneration.7 - 89%
Corvus.Json.CodeGeneration.CSharp - 90.6%
Corvus.Json.CodeGeneration.OpenApi30 - 79.6%
Corvus.Json.ExtendedTypes - 61.1%
Corvus.Json.JsonReference - 65.8%
Corvus.Json.Patch - 19.9%
Corvus.Json.Specs - 55.2%
|
Fixed typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparing the release for V4