Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start script fails after initial installation - After merge #488 #500

Closed
DennisOosterling opened this issue Nov 3, 2017 · 3 comments
Closed

Comments

@DennisOosterling
Copy link

Node version:
6.11.2

npm version:
3.10.10

Operating system:
Ubuntu 16.04

Command line used:
zsh

Steps to reproduce:

  1. git clone git clone https://github.com/coryhouse/react-slingshot.git
  2. npm setup
  3. npm start -s

Jest can't find tests.

Starting app in dev mode...
No tests found
In /home/dennis/Documents/MB/react-slingshot
  50 files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)(spec|test).js?(x) - 12 matches
  testPathIgnorePatterns: /node_modules/ - 50 matches
Pattern: "--watch" - 0 matches 
@velser
Copy link

velser commented Nov 3, 2017

Can confirm issue. Managed to solve problem with removing -k flag, as npm run test:watch exits(as it doesn't find any tests) and everything is killed.

Probably solution would be to fix "test:watch" with "test:watch": "jest --watch" as extra -- are used for npm argument passing. Saw pull request after writing solution :D #501

@coryhouse
Copy link
Owner

Thanks for reporting. Fixed!

@coryhouse
Copy link
Owner

Get latest. I just realized #497 was the root cause, so I moved us back to using concurrently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants