Skip to content

Commit

Permalink
Dont use junit_bazel.xml as testgrid output filename (knative#266)
Browse files Browse the repository at this point in the history
* Dont use junit_bazel.xml as output filename as this conflicts with bazel output file and gets overwritten

* Move filename to const
  • Loading branch information
srinivashegde86 authored and knative-prow-robot committed Nov 19, 2018
1 parent 6f35430 commit 77db40a
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion tools/testgrid/testgrid.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ import (
"os"
)

const (
// Default filename to store output that acts as input to testgrid.
// Should be of the form junit_*.xml
filename = "/junit_knative.xml"
)

// TestProperty defines a property of the test
type TestProperty struct {
Name string `xml:"name,attr"`
Expand Down Expand Up @@ -74,7 +80,8 @@ func CreateXMLOutput(ts TestSuite, artifactsDir string) error {
return err
}

outputFile := artifactsDir + "/junit_bazel.xml"
outputFile := artifactsDir + filename
log.Printf("Storing output in %s", outputFile)
f, err := os.Create(outputFile)
if err != nil {
return err
Expand Down

0 comments on commit 77db40a

Please sign in to comment.