fix field/method conflict

[fdymylja]

Given the following proto message type:

message Foo {
  string type = 1;
}

We will produce a Foo.Type field and a Foo.Type() protoreflect.MessageType method, this causes code conflicts.

If a message uses a reserved name, for the sake of simplicity, we should suffix the field with an underscore _.

I would also output a warning message that this is bad, and we might break it in the future (reason for breaking is that we are incompatible with protoc field codegen which I do not think is good).

[aaronc]

Getting these warnings now:

2021/12/15 11:12:07 Message cosmos.base.abci.v1beta1.StringEvent contains the reserved field name cosmos.base.abci.v1beta1.StringEvent.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.
2021/12/15 11:12:07 Message tendermint.crypto.ProofOp contains the reserved field name tendermint.crypto.ProofOp.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.
2021/12/15 11:12:07 Message tendermint.abci.RequestCheckTx contains the reserved field name tendermint.abci.RequestCheckTx.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.
2021/12/15 11:12:07 Message tendermint.abci.Event contains the reserved field name tendermint.abci.Event.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.
2021/12/15 11:12:07 Message tendermint.abci.Evidence contains the reserved field name tendermint.abci.Evidence.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.
2021/12/15 11:12:07 Message tendermint.types.Vote contains the reserved field name tendermint.types.Vote.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.
2021/12/15 11:12:07 Message tendermint.types.Proposal contains the reserved field name tendermint.types.Proposal.type which conflicts with protoreflect.Message interface implementation.
This field will be suffixed with an underscore '_'.
If you can change the message field name, please do so.
In a future iteration of pulsar we may make a breaking change to this practice in order to be compliant with field naming of the original golang protobuf implementation.

7 instances. Is this enough to merit finding another work-around?

[aaronc]

Plus a bunch of errors:

cosmos/tx/signing/v1beta1/signing.pulsar.go:1154:42: v.ProtoReflect undefined (type *SignatureDescriptor_Data_Single has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1160:42: v.ProtoReflect undefined (type *SignatureDescriptor_Data_Multi has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1235:78: (*SignatureDescriptor_Data_Single)(nil).ProtoReflect undefined (type *SignatureDescriptor_Data_Single has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1237:47: v.Single.ProtoReflect undefined (type *SignatureDescriptor_Data_Single has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1239:78: (*SignatureDescriptor_Data_Single)(nil).ProtoReflect undefined (type *SignatureDescriptor_Data_Single has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1243:77: (*SignatureDescriptor_Data_Multi)(nil).ProtoReflect undefined (type *SignatureDescriptor_Data_Multi has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1245:46: v.Multi.ProtoReflect undefined (type *SignatureDescriptor_Data_Multi has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1247:77: (*SignatureDescriptor_Data_Multi)(nil).ProtoReflect undefined (type *SignatureDescriptor_Data_Multi has no field or method ProtoReflect)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1270:36: impossible type assertion:
        *SignatureDescriptor_Data_Single does not implement protoreflect.ProtoMessage (missing ProtoReflect method)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1273:36: impossible type assertion:
        *SignatureDescriptor_Data_Multi does not implement protoreflect.ProtoMessage (missing ProtoReflect method)
cosmos/tx/signing/v1beta1/signing.pulsar.go:1273:36: too many errors

[aaronc]

Let's reopen this. I think it would be good to do the painful thing and not have to have the warning about fields getting renamed

[aaronc]

If there is a type with a field method conflict, we should do codegen using a struct for the fast refletion wrapper instead of an alias to avoid the field method conflict.

Currently we're generating a fast reflection wrapper like this

cosmos-proto/testpb/1.pulsar.go

Line 263 in 213b768

type fastReflection_A A

This causes a field method conflict because Type would be a struct field and an interface method on the wrapper. Using a struct instead of an alias for the wrapper would avoid this. Ex:

type fastReflection_A struct {
  a A
}

We should only use a struct when there is a conflict, because an alias is more performant otherwise.