cosmos-sdk-proto: Remove IBC protos in favour of the ibc-proto crate
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,9 +298,6 @@ fn copy_and_patch(src: impl AsRef<Path>, dest: impl AsRef<Path>) -> io::Result<( | |||
| "/// Generated server implementations.\n\ | |||
| #[cfg(feature = \"grpc\")]", | |||
| ), | |||
| // Use `tendermint_proto` as source of `google.protobuf` types | |||
| // TODO(tarcieri): figure out what's wrong with our `buf` config and do it there | |||
| ("::prost_types::", "::tendermint_proto::google::protobuf::"), | |||
There was a problem hiding this comment.
Oh hey, thanks for cleaning this up, I forgot to remove it when we fixed the buf config
tony-iqlusion
approved these changes
Aug 15, 2024
|
I could merge this and cut a |
Sounds good! |
|
Alright, let's do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of #459.
Best reviewed commit by commit.
Changes
ics23crate instead of bundling them incosmos-sdk-proto