feat(x/bank): add origin address in event multisend (#21460)

cosmos · Aug 29, 2024 · 33c463e · 33c463e
1 parent 43f59c8
commit 33c463e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/x/bank/keeper/keeper_test.go b/x/bank/keeper/keeper_test.go
@@ -1468,20 +1468,18 @@ func (suite *KeeperTestSuite) TestMsgMultiSendEvents() {
 	event1.Attributes = append(
 		event1.Attributes,
 		coreevent.Attribute{Key: banktypes.AttributeKeyRecipient, Value: acc2StrAddr},
+		coreevent.Attribute{Key: sdk.AttributeKeySender, Value: acc0StrAddr},
+		coreevent.Attribute{Key: sdk.AttributeKeyAmount, Value: newCoins.String()},
 	)
-	event1.Attributes = append(
-		event1.Attributes,
-		coreevent.Attribute{Key: sdk.AttributeKeyAmount, Value: newCoins.String()})
+
 	event2 := coreevent.Event{
 		Type:       banktypes.EventTypeTransfer,
 		Attributes: []coreevent.Attribute{},
 	}
 	event2.Attributes = append(
 		event2.Attributes,
 		coreevent.Attribute{Key: banktypes.AttributeKeyRecipient, Value: acc3StrAddr},
-	)
-	event2.Attributes = append(
-		event2.Attributes,
+		coreevent.Attribute{Key: sdk.AttributeKeySender, Value: acc0StrAddr},
 		coreevent.Attribute{Key: sdk.AttributeKeyAmount, Value: newCoins2.String()},
 	)
 	// events are shifted due to the funding account events

diff --git a/x/bank/keeper/send.go b/x/bank/keeper/send.go
@@ -172,6 +172,7 @@ func (k BaseSendKeeper) InputOutputCoins(ctx context.Context, input types.Input,
 		if err := k.EventService.EventManager(ctx).EmitKV(
 			types.EventTypeTransfer,
 			event.NewAttribute(types.AttributeKeyRecipient, out.Address),
+			event.NewAttribute(types.AttributeKeySender, input.Address),
 			event.NewAttribute(sdk.AttributeKeyAmount, out.Coins.String()),
 		); err != nil {
 			return err