fix: remove support for NoOptDefaultValue (#14985)

cosmos · Feb 9, 2023 · 3c53870 · 3c53870
1 parent da5db35
commit 3c53870
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 109 deletions.
diff --git a/api/cosmos/autocli/v1/options.pulsar.go b/api/cosmos/autocli/v1/options.pulsar.go
diff --git a/client/v2/autocli/flag/register.go b/client/v2/autocli/flag/register.go
@@ -104,7 +104,6 @@ func (b *Builder) addMessageFlags(ctx context.Context, flagSet *pflag.FlagSet, m
 			flag.Deprecated = opts.Deprecated
 			flag.ShorthandDeprecated = opts.ShorthandDeprecated
 			flag.Hidden = opts.Hidden
-			flag.NoOptDefVal = opts.NoOptDefaultValue
 		}
 	})
 

diff --git a/client/v2/autocli/query_test.go b/client/v2/autocli/query_test.go
@@ -53,8 +53,8 @@ var testCmdDesc = &autocliv1.ServiceCommandDescriptor{
 					DefaultValue: "3",
 				},
 				"u64": {
-					Usage:             "some random uint64",
-					NoOptDefaultValue: "5",
+					Usage:        "some random uint64",
+					DefaultValue: "5",
 				},
 				"deprecated_field": {
 					Deprecated: "don't use this",

diff --git a/proto/cosmos/autocli/v1/options.proto b/proto/cosmos/autocli/v1/options.proto
@@ -101,9 +101,6 @@ message FlagOptions {
   // default_value is the default value as text.
   string default_value = 4;
 
-  // default value is the default value as text if the flag is used without any value.
-  string no_opt_default_value = 5;
-
   // deprecated is the usage text to show if this flag is deprecated.
   string deprecated = 6;