address chris and bez comments

types/utils.go

@@ -37,8 +37,8 @@ func MustSortJSON(toSortJSON []byte) []byte {
 	return js
 }
 
-// marshals int64 to a bigendian byte slice so it can be sorted
-func Int64ToSortableBytes(i int64) []byte {
+// Int64ToBigEndian - marshals int64 to a bigendian byte slice so it can be sorted
+func Int64ToBigEndian(i int64) []byte {
 	b := make([]byte, 8)
 	binary.BigEndian.PutUint64(b, uint64(i))
 	return b

x/gov/keeper_keys.go

@@ -12,6 +12,8 @@ import (
 
 // Key for getting a the next available proposalID from the store
 var (
+	KeyDelimiter = []byte("/")
+
 	KeyNextProposalID           = []byte("newProposalID")
 	PrefixActiveProposalQueue   = []byte("activeProposalQueue")
 	PrefixInactiveProposalQueue = []byte("inactiveProposalQueue")
@@ -47,31 +49,31 @@ func ActiveProposalQueueTimePrefix(endTime time.Time) []byte {
 	return bytes.Join([][]byte{
 		PrefixActiveProposalQueue,
 		sdk.FormatTimeBytes(endTime),
-	}, []byte("/"))
+	}, KeyDelimiter)
 }
 
 // Returns the key for a proposalID in the activeProposalQueue
 func ActiveProposalQueueProposalKey(endTime time.Time, proposalID int64) []byte {
 	return bytes.Join([][]byte{
 		PrefixActiveProposalQueue,
 		sdk.FormatTimeBytes(endTime),
-		sdk.Int64ToSortableBytes(proposalID),
-	}, []byte("/"))
+		sdk.Int64ToBigEndian(proposalID),
+	}, KeyDelimiter)
 }
 
 // Returns the key for a proposalID in the activeProposalQueue
 func InactiveProposalQueueTimePrefix(endTime time.Time) []byte {
 	return bytes.Join([][]byte{
 		PrefixInactiveProposalQueue,
 		sdk.FormatTimeBytes(endTime),
-	}, []byte("/"))
+	}, KeyDelimiter)
 }
 
 // Returns the key for a proposalID in the activeProposalQueue
 func InactiveProposalQueueProposalKey(endTime time.Time, proposalID int64) []byte {
 	return bytes.Join([][]byte{
 		PrefixInactiveProposalQueue,
 		sdk.FormatTimeBytes(endTime),
-		sdk.Int64ToSortableBytes(proposalID),
-	}, []byte("/"))
+		sdk.Int64ToBigEndian(proposalID),
+	}, KeyDelimiter)
 }