Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulations: different account types #10495

Closed
4 tasks
Tracked by #384
tomtau opened this issue Nov 4, 2021 · 2 comments
Closed
4 tasks
Tracked by #384

Simulations: different account types #10495

tomtau opened this issue Nov 4, 2021 · 2 comments

Comments

@tomtau
Copy link
Contributor

tomtau commented Nov 4, 2021 •
edited
Loading

Summary

Right now, generated accounts are fixed to base and vesting accounts, but it'd be good to add other account type support.

Problem Definition

I came across this when trying to implement simulations for Ethermint which has its custom account type: https://github.com/tharsis/ethermint/blob/c73ce0f812fa3885b8dffcdd47dc7e5cc8446b2b/types/account.go

Proposal

Not sure what the best way is to include it -- perhaps some form of extending the basic simulations functions to be able to add custom account look ups etc.
Also related issues:
#10087
#8201

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
tomtau added a commit to tomtau/cronos that referenced this issue Nov 15, 2021
@tomtau
Problem: simulations don't simulate cronos-related functionality (fixes
5c72944 
crypto-org-chain#150)

Solution:
- removed the sims pipelines temporarily:
1) sims-protected doesn't appear to be ever executed
2) sims take a lot of CI time (~1.5hour each) despite not being useful
- currently blocked by evmos/ethermint#658 cosmos/cosmos-sdk#10495 etc.
@tomtau tomtau mentioned this issue Nov 15, 2021
Merged
tomtau added a commit to crypto-org-chain/cronos that referenced this issue Nov 16, 2021
@tomtau
Problem: simulations don't simulate cronos-related functionality (fixes
4725cf0 
#150) (#212)

Solution:
- removed the sims pipelines temporarily:
1) sims-protected doesn't appear to be ever executed
2) sims take a lot of CI time (~1.5hour each) despite not being useful
- currently blocked by evmos/ethermint#658 cosmos/cosmos-sdk#10495 etc.
@alexanderbez
Copy link
Contributor

Simulations actually use base and vesting accounts FYI 👌

@yihuang yihuang mentioned this issue Mar 9, 2022
Closed
4 tasks
@tomtau
Copy link
Contributor Author

tomtau commented Apr 19, 2022

possible workaround: evmos/ethermint#996 (using a custom RandomGenesisAccounts)

@tomtau tomtau closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomtau @alexanderbez