Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set signingInfo.StartHeight on bonding a new validator #1199

Closed
cwgoes opened this issue Jun 11, 2018 · 0 comments · Fixed by #1200
Closed

Set signingInfo.StartHeight on bonding a new validator #1199

cwgoes opened this issue Jun 11, 2018 · 0 comments · Fixed by #1200
Assignees
@cwgoes
Labels
C:x/slashing T:Bug

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jun 11, 2018

The current logic in x/slashing will treat a newly added validator as having started at sign height of 0, and will immediately unbond them. This is (obviously) incorrect. The slashing module should instead set the signing start height of a new validator to the current block height when it first becomes a validator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
C:x/slashing T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slashing bugfixes (start height, handler registration) cosmos/cosmos-sdk
1 participant
@cwgoes