Slashing bugfixes (start height, handler registration) #1200
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1200 +/- ##
===========================================
+ Coverage 65.23% 65.46% +0.23%
===========================================
Files 87 87
Lines 4415 4428 +13
===========================================
+ Hits 2880 2899 +19
+ Misses 1356 1350 -6
Partials 179 179 |
cwgoes
changed the title
|
so we found out the root cause of #1197? |
x/slashing/keeper_test.go
Outdated
| @@ -129,3 +129,36 @@ func TestHandleAbsentValidator(t *testing.T) { | |||
| validator, _ = sk.GetValidatorByPubKey(ctx, val) | |||
| require.Equal(t, sdk.Unbonded, validator.GetStatus()) | |||
| } | |||
|
|
|||
| func TestHandleNewValidator(t *testing.T) { | |||
There was a problem hiding this comment.
Can we add a small description (couple sentences) explaining the intention of this test... looks cool, I'd like to better understand the scenario
There was a problem hiding this comment.
Added a few-line description to all tests in this file.
x/slashing/keeper.go
Outdated
| if !found { | ||
| // If this validator has never been seen before, set the start height | ||
| signInfo.StartHeight = height | ||
| } |
There was a problem hiding this comment.
I tend to think this isn't the best practice - it would be more clear to have a NewSignInfo function where you pass in the height and we explicitly define signInfo with this function if !found - this way we can remove that second comment there that rationalizes what is happening - it will just be implied by the code
There was a problem hiding this comment.
Agreed - that's clearer - changed to NewValidatorSigningInfo.
Closes #1199
Closes #1196
Can be cherry-picked for a testnet hotfix. This PR does change the state machine.