-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseapp: Init contradictorily checks if app.cms == nil after invoking app.setState which blindly dereferences app.cms + app.Seal which will cause nil pointer panics or prevent any progress since sealed=true #18726
Labels
Comments
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
odeke-em
added a commit
that referenced
this issue
Dec 13, 2023
This change ensures that we correctly check if the app has a nil commit multistore before trying to dereference it or invoking .Seal() Fixes #18726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we examine this code
cosmos-sdk/baseapp/baseapp.go
Lines 429 to 437 in 570ab64
cosmos-sdk/baseapp/baseapp.go
Line 481 in 570ab64
But later down we have a check for app.cms == nil
cosmos-sdk/baseapp/baseapp.go
Lines 433 to 436 in 570ab64
That's a contradiction right there and would result in a nil panic, even more by invoking app.Seal() firstly we make it so that any failure thats fixed by now setting a cms then that's rechecked then .Init() is retried will just fail with no meaningful progress. We should move that check up before setState
The text was updated successfully, but these errors were encountered: