Rename AccountMapper to AccountKeeper

[jackzampolin]

To avoid confusion. @sunnya97 is under the impression we retired the Mapper terminology.

[ValarDragon]

I don't really like AccountKeeper. Mapper describes exactly what its doing. I think AccountKeeper is confusing, and only increases the barrier to understanding here.

[sunnya97]

@ValarDragon What's the difference between a Mapper and a Keeper?

I think its easier just to merge these terminologies.

[ValarDragon]

map is a fairly universal term throughout most of CS, and mathematics. The AccountMapper is a function which maps an address to an account.

The AccountKeeper is much less intuitive imo. Keeper does not have an intrinsic meaning which tells you what it does. This is fine for modules, where they have more complex functionality. I don't think this is a good idea for accounts, where there is a single purpose for this object.

[alexanderbez]

I guess this begs the question, what cause for the initial confusion?

[jackzampolin]

I think there is still some work that needs to be done here to rename the AccountMapper to the AccountKeeper on develop the file names are still mapper.go. I bet theres also some other spots that need to be updated.

[alexanderbez]

Was just about to say that 😆

[fedekunze]

I think this is mostly resolved, closing.