Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gaiacli config command #2734

Closed
jackzampolin opened this issue Nov 8, 2018 · 2 comments
Closed

Fix gaiacli config command #2734

jackzampolin opened this issue Nov 8, 2018 · 2 comments
Assignees
@alessio
Labels
C:CLI

Comments

@jackzampolin
Copy link
Member

This command is currently broken. Also there is no non-interactive version.
@jdkanani
Copy link

jdkanani commented Nov 13, 2018 •
edited
Loading

Is there any reason for not separating gaia-testnet/GoS and cosmos SDK?

Changing SDK for Gaia seems unreasonable. I see SDK as SDK (not used directly in any-case), and examples can have basecoin, gaia/GoS (or have different repository which uses SDK internally).

Or I'm missing something very obvious!

@alexanderbez
Copy link
Contributor

@jdkanani Gaia the application will be moved out into its own repository soon.

@alessio alessio mentioned this issue Dec 1, 2018
Merged
5 tasks
@alessio alessio self-assigned this Dec 1, 2018
alessio pushed a commit that referenced this issue Dec 1, 2018
Fix gaiacli config and make it non-interactive only
2945018 
Closes: #2734
@alessio alessio added the C:CLI label Dec 1, 2018
alessio pushed a commit that referenced this issue Dec 4, 2018
Fix gaiacli config and make it non-interactive only
7b94da2 
Closes: #2734
cwgoes pushed a commit that referenced this issue Dec 4, 2018
@alessio @cwgoes
Merge PR #2972: Fix gaiacli config and make it non-interactive only
d32e4a9 
* Fix gaiacli config and make it non-interactive only

Closes: #2734

* Update cli tests

* Remove --list, by default and with no args print config

* Small improvements

* Warn user when file doesn't exist

* Fix integration tests
mircea-c pushed a commit that referenced this issue Dec 5, 2018
@alessio
Merge PR #2972: Fix gaiacli config and make it non-interactive only
0e0b9e8 
* Fix gaiacli config and make it non-interactive only

Closes: #2734

* Update cli tests

* Remove --list, by default and with no args print config

* Small improvements

* Warn user when file doesn't exist

* Fix integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alessio @jdkanani @alexanderbez @jackzampolin