Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bank.MsgIssue can be constructed in a valid tx, but will cause a panic #2854

Closed
cwgoes opened this issue Nov 19, 2018 · 0 comments
Closed

bank.MsgIssue can be constructed in a valid tx, but will cause a panic #2854

cwgoes opened this issue Nov 19, 2018 · 0 comments
Assignees
@cwgoes
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:Bug

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 19, 2018

Discovered while working on #2853.

I'm not sure of the initial intent, but we don't implement a handler for bank.MsgIssue - instead we just panic: https://github.com/cosmos/cosmos-sdk/blob/develop/x/bank/handler.go#L36

I propose we remove the handler and remove MsgIssue, as I don't think we require it at launch.
@cwgoes cwgoes added T:Bug core T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Nov 19, 2018
@cwgoes cwgoes self-assigned this Nov 19, 2018
@cwgoes cwgoes mentioned this issue Nov 19, 2018
Merged
5 tasks
@cwgoes cwgoes mentioned this issue Nov 22, 2018
Merged
4 tasks
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@mmulji-ic
docs: Gaia v14 upgrade hermes update (cosmos#2854)
2dc2b82 
* Updated v14 migration information with relayer information

* Removed ICS goto market doc

* Added ICS docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwgoes