-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int128 support #306
Comments
It might even make sense to create a Uint128/64 that panics or errors instead of overflowing or going below 0. It has semantic meaning that this number can't be negative, and it just reduces lines of code where we'd have to check for < 0. (One reason why uint* sucks is because they underflow to a high number. That's why we use int* for numbers we'll do arithmetic on). |
We could just impose a hard limit the amount atoms that could be in an account, If you've got a crazy amount of atoms, you'll just need multiple accounts |
Closing in favor of #977. |
feat: merge cosmos-sdk v0.45.16
W/ 240M atoms and 8 decimal places, we brush up on 2^53, which is the limit for javascript precise arithmetic without going to big-int libraries. That lead to a discussion of whether we should support > 2^53 tokens per coin, and whether we should support 2^64, or even 2^128 or 2^256. (actually 2^63-1, 2^127-1, and 2^255-1 respectively due to signing).
Benefits of Int128:
Downsides of Int128:
The text was updated successfully, but these errors were encountered: