Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: staking spec upgrades / some renaming #3357

Merged
merged 22 commits into from
Feb 8, 2019

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jan 23, 2019

closes #3324

There are still slashing sections to be filled in for slashing in state-transitions.md but the motivation for me to complete this as a part of this PR doesn't exist, I suggest we merge what is here for now.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski added T:Docs Changes and features related to documentation. spec C:x/staking wip labels Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #3357 into develop will increase coverage by 0.1%.
The diff coverage is 58.92%.

@@            Coverage Diff             @@
##           develop    #3357     +/-   ##
==========================================
+ Coverage    55.51%   55.61%   +0.1%     
==========================================
  Files          141      141             
  Lines        10445    10437      -8     
==========================================
+ Hits          5799     5805      +6     
+ Misses        4306     4293     -13     
+ Partials       340      339      -1

@cwgoes
Copy link
Contributor

cwgoes commented Feb 5, 2019

This looks like a fair amount of staking code changes too - just general cleanup?

@rigelrozanski
Copy link
Contributor Author

@cwgoes yes cleanup - also some name changes per the issue

@rigelrozanski rigelrozanski changed the title WIP: staking spec minor upgrades WIP: staking spec upgrades / some renaming Feb 7, 2019
@rigelrozanski rigelrozanski changed the title WIP: staking spec upgrades / some renaming R4R: staking spec upgrades / some renaming Feb 7, 2019
docs/spec/staking/overview.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Show resolved Hide resolved
docs/spec/staking/state.md Show resolved Hide resolved
docs/spec/staking/state_transitions.md Show resolved Hide resolved
docs/spec/staking/state_transitions.md Show resolved Hide resolved
docs/spec/staking/state_transitions.md Show resolved Hide resolved
x/staking/keeper/delegation.go Outdated Show resolved Hide resolved
x/staking/keeper/validator.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #3357 into develop will increase coverage by 0.09%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##           develop    #3357      +/-   ##
===========================================
+ Coverage    61.25%   61.35%   +0.09%     
===========================================
  Files          185      185              
  Lines        13982    13978       -4     
===========================================
+ Hits          8565     8576      +11     
+ Misses        4874     4860      -14     
+ Partials       543      542       -1

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM; a few nits and let's wait for #3507 first.

docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state_transitions.md Outdated Show resolved Hide resolved
docs/spec/staking/state_transitions.md Show resolved Hide resolved
x/staking/keeper/val_state_change.go Outdated Show resolved Hide resolved
x/staking/keeper/validator.go Show resolved Hide resolved
x/staking/keeper/validator.go Show resolved Hide resolved
@rigelrozanski
Copy link
Contributor Author

will wait for #3507 merge before fixes

@jackzampolin
Copy link
Member

This needs a rebase cause #3507

@cwgoes cwgoes merged commit 7f74b33 into develop Feb 8, 2019
@cwgoes cwgoes deleted the rigel/staking-spec-upgradesx2 branch February 8, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/staking spec T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking spec updates x2
4 participants