R4R: power reduction for Tendermint #3400

rigelrozanski · 2019-01-25T22:10:58Z

closes #2513

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/) - should be added to the state transitions document for validator set updates in R4R: staking spec upgrades / some renaming #3357
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

cwgoes

(quick initial pass)

types/stake.go

x/staking/types/validator.go

…reduce

x/gov/tally.go

types/stake.go

cwgoes · 2019-01-30T01:36:45Z

(otherwise this approach seems fine to me)

docs/.vuepress/config.js

…reduce

x/staking/types/validator.go

client/lcd/test_helpers.go

cwgoes

Mostly looks solid (lots of testcase changes!) - a few comments on the core implementation.

PENDING.md

x/staking/types/validator.go

…reduce

x/staking/types/validator.go

add uncompiled power functionality

4ea3477

rigelrozanski added C:x/staking wip labels Jan 25, 2019

rigelrozanski requested review from cwgoes and ebuchman as code owners January 25, 2019 22:10

fix some compile errors

3b0f7c6

cwgoes reviewed Jan 28, 2019

View reviewed changes

types/stake.go Outdated Show resolved Hide resolved

x/staking/types/validator.go Show resolved Hide resolved

rigelrozanski added 3 commits January 29, 2019 15:13

Merge remote-tracking branch 'origin/develop' into rigel/tmint-power-…

1bd2fbf

…reduce

Power -> TendermintPower

874f065

tests rename GetTendermintPower

af5a1e3

rigelrozanski requested a review from zramsay as a code owner January 29, 2019 23:28

test fix

5ec0826

cwgoes suggested changes Jan 30, 2019

View reviewed changes

x/gov/tally.go Outdated Show resolved Hide resolved

types/stake.go Show resolved Hide resolved

rigelrozanski added 4 commits January 29, 2019 18:39

working

b792be6

fix delegation tests

bce1ff0

fix slash tests

5fb7d78

staking/keeper tests passing

31c2b8e

zramsay reviewed Jan 30, 2019

View reviewed changes

docs/.vuepress/config.js Outdated Show resolved Hide resolved

rigelrozanski added 11 commits January 30, 2019 10:57

docs reversion

753e71b

debuggin workin

0a71ae3

x/staking test pass

500ae2d

fix gov tests

93a9d66

fix x/slashing tests

2f5ae44

working distribution test fixes

328b7bf

fix distribution tests

7958a14

lint

f7c7a1d

fix lcd tests

836e963

fix gov test

bba4591

lint

079b4ad

rigelrozanski added 6 commits January 31, 2019 19:34

working cli fixes

6ac2afd

Merge remote-tracking branch 'origin/develop' into rigel/tmint-power-…

9f42196

…reduce

cli test fix

239f145

cli tests fixed

8dcf0d7

testnet creation modification

49c1a3c

typo

b1db0f4

rigelrozanski changed the title ~~WIP: power reduction for Tendermint~~ R4R: power reduction for Tendermint Feb 1, 2019

rigelrozanski added ready-for-review and removed wip labels Feb 1, 2019

pending

d2cc658

alexanderbez reviewed Feb 1, 2019

View reviewed changes

x/staking/types/validator.go Outdated Show resolved Hide resolved

client/lcd/test_helpers.go Outdated Show resolved Hide resolved

ebuchman mentioned this pull request Feb 1, 2019

proposer priority fixes follow up tendermint/tendermint#3166

Closed

11 tasks

This was referenced Feb 1, 2019

Exp function for sdk.Int sdk.Uint #3471

Closed

Check input sanitization for rounded decimals #2509

Closed

Sanitize Dec.Roundint64 (#3475)

b2241ef

cwgoes suggested changes Feb 4, 2019

View reviewed changes

PENDING.md Outdated Show resolved Hide resolved

PENDING.md Outdated Show resolved Hide resolved

x/staking/types/validator.go Outdated Show resolved Hide resolved

x/staking/types/validator.go Outdated Show resolved Hide resolved

x/staking/types/validator.go Outdated Show resolved Hide resolved

rigelrozanski added 6 commits February 5, 2019 16:44

Merge remote-tracking branch 'origin/develop' into rigel/tmint-power-…

7df1018

…reduce

merge fixes

cefba46

@cwgoes comments

5e95340

fix tests

a952a41

change power reduction to 10^-6

a984da1

option to turn off minting for LCD tests

450cad0

alexanderbez approved these changes Feb 6, 2019

View reviewed changes

cwgoes reviewed Feb 6, 2019

View reviewed changes

x/staking/types/validator.go Show resolved Hide resolved

cwgoes approved these changes Feb 6, 2019

View reviewed changes

Merge branch 'develop' into rigel/tmint-power-reduce

f8c1ffc

jackzampolin added the will-merge label Feb 6, 2019

rigelrozanski merged commit 52f2ec7 into develop Feb 6, 2019

rigelrozanski deleted the rigel/tmint-power-reduce branch February 6, 2019 05:30

rigelrozanski mentioned this pull request Feb 14, 2019

R4R: mint use total supply instead of power #3654

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R4R: power reduction for Tendermint #3400

R4R: power reduction for Tendermint #3400

rigelrozanski commented Jan 25, 2019 •

edited

Loading

cwgoes left a comment

cwgoes commented Jan 30, 2019

cwgoes left a comment

R4R: power reduction for Tendermint #3400

R4R: power reduction for Tendermint #3400

Conversation

rigelrozanski commented Jan 25, 2019 • edited Loading

cwgoes left a comment

Choose a reason for hiding this comment

cwgoes commented Jan 30, 2019

cwgoes left a comment

Choose a reason for hiding this comment

rigelrozanski commented Jan 25, 2019 •

edited

Loading