Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gaiad toml config #4125

Closed
4 tasks
alexanderbez opened this issue Apr 15, 2019 · 5 comments
Closed
4 tasks

Rename gaiad toml config #4125

alexanderbez opened this issue Apr 15, 2019 · 5 comments
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@alexanderbez
Copy link
Contributor

Summary

BaseApp/node configuration that is not specific to Tendermint (eg. min gas prices) currently may be provided via CLI flags or through a configuration file. The latter is hard-coded to gaiad.toml in interceptLoadConfig. This really has nothing to do with Gaia and should be renamed to server.toml or node.toml.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. configuration labels Apr 15, 2019
@alessio
Copy link
Contributor

alessio commented Apr 15, 2019

I agree. We need to work out and upgrade path as well - see tendermint's priv_validator_key split, they made a bunch of functions that migrate config smoothly.

@alessio
Copy link
Contributor

alessio commented Apr 15, 2019

Furthermore (but this may happen at a later stage) we should provide the client app with a mechanism to customise server's commands (e.g. the start command) by passing extra flags. See the unfortunate case of --inv-check-period for instance.

@alexanderbez
Copy link
Contributor Author

Yes, this can really be done as part of this. I don't see why not. Seems like a simple hook/callback.

@alessio
Copy link
Contributor

alessio commented Apr 15, 2019

I'm fine with that

@fedekunze
Copy link
Collaborator

I think this was resolved on the Gaia split. From the 0.36 changelog:

#4104 Rename gaiad.toml to app.toml. The internal contents of the application config remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

No branches or pull requests

3 participants